Fix missing trailing return type in __when_all_impl::__get_env - #2237
Open
maartenarnst wants to merge 1 commit into
Open
Fix missing trailing return type in __when_all_impl::__get_env#2237maartenarnst wants to merge 1 commit into
__when_all_impl::__get_env#2237maartenarnst wants to merge 1 commit into
Conversation
Signed-off-by: Maarten Arnst <maarten.arnst@uliege.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2124, the trailing return type was removed from
__when_all_impl::__get_env. This forces early instantiation of downstreamget_env, which in turn may cause compilation errors when downstream types are still incomplete. This PR restores the trailing return type.@RobertLeahy